Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONT-1149-erb_to_epp_conversion_tomcat #541

Merged
merged 1 commit into from
Jul 27, 2023
Merged

CONT-1149-erb_to_epp_conversion_tomcat #541

merged 1 commit into from
Jul 27, 2023

Conversation

praj1001
Copy link
Contributor

@praj1001 praj1001 commented Jul 25, 2023 •
edited
Loading

Summary

Conversion of ERB template to EPP template for tomcat module.

Additional Context

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@praj1001 praj1001 requested a review from a team as a code owner July 25, 2023 10:02
@praj1001 praj1001 force-pushed the CONT-1149-erb_to_epp_conversion_tomcat branch from 0724d6a to 417e4cb Compare July 27, 2023 11:45
jordanbreen28
jordanbreen28 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job @praj1001

@jordanbreen28 jordanbreen28 merged commit b0f2c36 into main Jul 27, 2023
@jordanbreen28 jordanbreen28 deleted the CONT-1149-erb_to_epp_conversion_tomcat branch July 27, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanbreen28 jordanbreen28 jordanbreen28 approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praj1001 @jordanbreen28