Fixes for Leatherman 0.6.0 on stable #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @parisiale, this blocks puppetlabs/puppet-agent#639, needed for some Facter fixes. |
|
This all looks fine to me (especially since it's mostly cherry-picks). I'd like a +1 from someone on the team, though |
|
There were a lot of cherry-picks, so I'd like confirmation I got them all cleanly. |
Updating tests/main.cc to Catch v1.4.0 changes.
Removing the Catch's applyCommandLine() and passing CLI arguments directly to the Session::run() function; note that setting ConfigData showDurations to "Always" works in the same way as it's not changed by our CI pipeline via CLI.
Clang warns about moving in return statements, which prevents copy elision. Avoid move statements in the return statement.
It should contain no source code changes compared to 0.5.1, so don't update the README. But ensure testing happens against the latest version we're using for packaging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.