Increase default pool_size to 4

CHANGELOG.mkd

@@ -2,6 +2,7 @@ CHANGELOG
 =========
 
 Unreleased
+ - Increase pool_size default to 4 from 1 [#1044](https://github.com/puppetlabs/r10k/pull/1044)
 ----
 
 3.4.1

lib/r10k/puppetfile.rb

@@ -10,7 +10,7 @@ class Puppetfile
 
   include R10K::Settings::Mixin
 
-  def_setting_attr :pool_size, 1
+  def_setting_attr :pool_size, 4
 
   include R10K::Logging
 

lib/r10k/settings.rb

@@ -159,8 +159,8 @@ def self.global_settings
         }),
 
         Definition.new(:pool_size, {
-          :desc => "The amount of threads used to concurrently install modules. The default value is 1: install one module at a time.",
-          :default => 1,
+          :desc => "The amount of threads used to concurrently install modules. The default value is 4: install four modules at a time.",
+          :default => 4,
           :validate => lambda do |value|
             if !value.is_a?(Integer)
               raise ArgumentError, "The pool_size setting should be an integer, not a #{value.class}"

spec/unit/action/puppetfile/install_spec.rb

@@ -19,7 +19,9 @@ def installer(opts = {}, argv = [], settings = {})
 
   describe "installing modules" do
     let(:modules) do
-      Array.new(4, R10K::Module::Base.new('author/modname', "/some/nonexistent/path/modname", nil))
+      (1..4).map do |idx|
+        R10K::Module::Base.new("author/modname#{idx}", "/some/nonexistent/path/modname#{idx}", nil)
+      end
     end
 
     before do