Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RK-135) Improve error message when no published mod versions exist #1177

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

Magisus
Copy link
Collaborator

@Magisus Magisus commented Jul 1, 2021

This previously would throw an undefined method error when
current_release was nil. Now, we check for that case and raise
something that will be meaningful to the user.

Please add all notable changes to the "Unreleased" section of the CHANGELOG in the format:

- (JIRA ticket) Summary of changes. [Issue or PR #](link to issue or PR)

@Magisus Magisus requested a review from a team July 1, 2021 22:29
@Magisus Magisus force-pushed the missing-mod-version branch 2 times, most recently from 9aed057 to 26f8d19 Compare July 1, 2021 22:56
This previously would throw an undefined method error when
`current_release` was nil. Now, we check for that case and raise
something that will be meaningful to the user.
@Magisus Magisus force-pushed the missing-mod-version branch from 26f8d19 to fec4b31 Compare July 1, 2021 23:17
@justinstoller justinstoller merged commit 4c4b74d into puppetlabs:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants