(maint) Define statically_defined_version for local modules
#1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `statically_defined_version` method to the `R10K::Module::Local` class. This method is called when instantiating a new module definition, so previously, Puppetfiles that defined local modules could not be evaluated because the method was missing.
mwaggett
force-pushed
the
maint/main/statically-defined-version-local
branch
from
6670da6 to
3e7aceb
Compare
| @@ -11,10 +11,14 @@ def self.implement?(name, args) | |||
| args.is_a?(Hash) && (args[:local] || args[:type].to_s == 'local') | |||
| end | |||
|
|
|||
| def version | |||
| def self.statically_defined_version(name, args) | |||
There was a problem hiding this comment.
Since these args aren't used, should we drop them?
There was a problem hiding this comment.
No, we call this with args, since the other module types use them in their implementations: https://github.com/puppetlabs/r10k/blob/main/lib/r10k/module/definition.rb#L11
There was a problem hiding this comment.
In that case, it should be just *.
There was a problem hiding this comment.
Do you want to make that edit?
mwaggett
force-pushed
the
maint/main/statically-defined-version-local
branch
from
3e7aceb to
cbcabdb
Compare
justinstoller
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
statically_defined_versionmethod to theR10K::Module::Localclass. This method is called when instantiating a newmodule definition, so previously, Puppetfiles that defined local modules could
not be evaluated because the method was missing.