Align terminology with Puppet; bare => plain #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaggett
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
This generally looks good! Just a couple small nits, and this needs a rebase.
We're planning to do an r10k release today, so if you could make those tweaks ASAP, that would be great! Otherwise, if you don't mind (and perms allow), I can force-push to your branch to get this fixed up.
spec/unit/environment/plain_spec.rb
Outdated
Comment on lines
5
to
6
| let(:basepath) { '/some/imaginary/path' } | ||
| let(:envname) { 'env_name' } |
There was a problem hiding this comment.
Doesn't look like these lets are needed, if you're just using string params below.
|
also @reidmv if you wouldn't mind opening an RK ticket for removing the |
Puppet already uses a term in the indirector system to indicate that an implementation doesn't really do anything, and that term is "plain". For the R10K environment type that doesn't do anything, we should use this same terminology. The initial choice of the term "bare" isn't ecosystem congruent, and has the language problem of being used meaningfully when describing Git repos, but that meaning doesn't translate at all to the environment type. Using the term "plain" both aligns terminology with Puppet, and eliminates any potential language collisions with the Git meaning of the term.
mwaggett
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet already uses a term in the indirector system to indicate that an implementation doesn't really do anything, and that term is "plain". For the R10K environment type that doesn't do anything, we should use this same terminology. The initial choice of the term "bare" isn't ecosystem congruent, and has the language problem of being used meaningfully when describing Git repos, but that meaning doesn't translate at all to the environment type.
Using the term "plain" both aligns terminology with Puppet, and eliminates any potential language collisions with the Git meaning of the term.
I doubt this feature is much-used, and it's still documented as "experimental" so we could probably just change the name and be done. The PR includes a formal deprecation just in case anyone thinks it's needed pre-4.0.
Please add all notable changes to the "Unreleased" section of the CHANGELOG in the format: