(RK-399) Do not warn on spec changes with exclude_spec #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, r10k would warn about local changes on the files in the spec dir when exclude_spec was set. Since r10k was removing the files, the warning would always be present for each git module when exclude_spec was set. This change removes the spec files from the insync checks so that it will not be marked as dirty if there are only changes to the spec files. After this change, the warning about local modifications on the spec files should not be present.
|
Thanks for doing this @jarretlavallee ! I'll take it for a spin later today. |
tvpartytonight
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, r10k would warn about local changes on the files
in the spec dir when exclude_spec was set. Since r10k was removing the
files, the warning would always be present for each git module when
exclude_spec was set. This change removes the spec files from the insync
checks so that the repo will not be marked as dirty if there are only changes
to the spec files. After this change, the warning about local
modifications on the spec files should not be present.