(maint) Allow 'file' transport when adding git submodules #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a recent CVE, the 'file' transport is considered unsafe by default. This results in an error when attempting to add submodules on ubuntu. This commit explicitly allows the 'file' transport protocol when adding submodules in acceptance tests. For more info, see https://github.blog/2022-10-18-git-security-vulnerabilities-announced/#cve-2022-39253
As of Bundler 2.4.0, Ruby >= 2.6.0 is required, so this commit pins Bundler to a version that supports Ruby 2.4 and 2.5, since we still support those versions.
This commit ensures that puppet_forge >= 4.0.0 is not used, since 4.0.0 drops support for Ruby versions < 2.6 and we still support 2.4 and 2.5.
jonathannewman
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a recent CVE, the 'file' transport is considered unsafe by default. This results in an error when attempting to add submodules on ubuntu. This commit explicitly allows the 'file' transport protocol when adding submodules in acceptance tests.
For more info, see https://github.blog/2022-10-18-git-security-vulnerabilities-announced/#cve-2022-39253