(maint) Support more minitar versions #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes us from requiring at least minitar 1.0 and instead goes to the previous minimum verion (0.9), but instead of using a "~>" which forbids going to a new major release, ie is equivalent to [">= 0.9", "< 1.0"] we simply require above the previous version, not caring if we take up a new major release. This allows us to be installed in the same version Ruby bundle as Puppet (which currently does not support minitar >= 1.0). Minitar has supported the "new" `::Minitar` constant since before 0.9, so there are no code changes required.
Co-authored-by: Tim Meusel <[email protected]>
Co-authored-by: Tim Meusel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks the non-5.0 release task commits from #1408 so we can see the changes go green in our CI before merging the release task.
Please add all notable changes to the "Unreleased" section of the CHANGELOG in the format: