Integrate with read-extended-command-predicate
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I see that the suspicion with older Emacsen was correct, given that my tests fail with Emacs 27 CI. Should the feature itself be made conditional, or does it suffice that most likely only people opt in that do use |
kenranunderscore
force-pushed
the
add-mode-specific-commands
branch
from
da57081 to
dce9c3f
Compare
Adds the option to specify a list of modes that the interactive commands are defined for. This way, people using a `read-extended-command-predicate' may have the "-region" and "-buffer" commands only available via M-x in those modes.
|
I opted for the latter, that is, only defining/running those tests Some of the tests have pretty long lines; is that ok? |
|
Friendly bump :) |
|
Thanks, yeah, long test lines are fine. Merging now! 🚀🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Since Emacs 28.1 (I think) we have the option to add modes to
interactive, say(interactive nil haskell-mode emacs-lisp-mode). The Emacs variableread-extended-command-predicate(when set to some predicate, for instancecommand-completion-default-include-p) then leads to those commands only being shown inM-xcompletion when the current buffer is in one of those modes.I've added the
:interactive-modeskeyword, taking a list of those modes that are then passed tointeractive, and tested it accordingly.Some points/questions:
:modeswould (I think) suggest something regarding the created minor mode, or similar to the:hooksbehaviour inuse-package, so I opted for a longer name giving theinteractivecontext.:interactive-modesexpects an unquoted list of modes. It was easiest to implement it this way, as we can just splice it intointeractive, which takes them as&rest. Is this fine?I personally find it very handy and nice to have my custom commands automatically narrowed down like this; just the ones defined with
reformatter-define"stick out" a little bit, hence this PR. I'd be glad if you considered this in some way or other :)