Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 determine joystick status by pid in resolve_v5_port #386

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AndrewLuGit
Copy link
Contributor

Summary:

In addition to checking the description, also check if the pid is equal to 0x503 to determine if a device is a joystick in resolve_v5_port

Motivation:

The value of is_joystick is crucial to the functionality of the pros terminal, as if it is a joystick the controller must be switched to the download channel. On Windows computers, vex brains and controllers show up with a generic description of "USB Serial Device", unless you install the vex USB drivers, which gives them their proper names. This means that currently is_joystick returns False for controllers on Windows computers without the vex drivers, which breaks pros terminal on Windows.

References (optional):

#383

Test Plan:

  • test that pros terminal works over controllers on Windows computers
  • test that nothing else has broken, e.g. uploading programs, pros terminal from brain, pros terminal on Linux and macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant