🐛 determine joystick status by pid in resolve_v5_port #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In addition to checking the description, also check if the pid is equal to 0x503 to determine if a device is a joystick in resolve_v5_port
Motivation:
The value of is_joystick is crucial to the functionality of the pros terminal, as if it is a joystick the controller must be switched to the download channel. On Windows computers, vex brains and controllers show up with a generic description of "USB Serial Device", unless you install the vex USB drivers, which gives them their proper names. This means that currently is_joystick returns False for controllers on Windows computers without the vex drivers, which breaks pros terminal on Windows.
References (optional):
#383
Test Plan: