✨Increasing the Max String Size on the Controller Display

[WillXuCodes]

Summary:

VCS and RMS have had their controller max string sizes at 19 for a while, and PROS also having this wouldn't be too hard of a change. This was done by changing `CONTROLLER_MAX_COLS` under `src/devices/controller.c` to 19.

Motivation:

There was an issue opened by @djava requesting that we do this, but the discussion surround this died pretty suddenly so I decided to open a PR regarding this to restart the conversation

References (optional):

fixes #217

Test Plan:

• Build and Upload to a robot with a 19 character display, see if it shows up.

[kunwarsahni01]

LGTM

[nathan-moore]

You'll probably have to increase this line

pros/src/devices/controller.c

Line 262 in 337b4c5

static const char* clear = " ";

Probably should make sure all the clears work correctly (including the fallback for the screen clear).

Btw, I edited the post to reference the issue correctly.

[djava]

Seems worth a try at least putting it to like 50 and and just filling it with I's.
It's probably a VexOS limit at 19 if that's what RMS does but not necessarily

[WillXuCodes]

Somebody with a controller could probably try that, but for pros itself the 19 limit seems reasonable given the small amount of space left with the 19 character word in the test case.

[kunwarsahni01]

I tried increasing it to 20, the max number of characters that the controller will display is 19.

[nathan-moore]

LGTM baring some additional testing around clearing. If you want to be though, you could test line clearing and both versions of screen clearing still work. Consider adding that assert, as it makes finding this dependency easier.

[nathan-moore]

LGTM baring some additional testing around clearing. If you want to be thorough, you could test line clearing and both versions of screen clearing still work.