Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -webkit and -moz prefixes for border-radius, text-shadow #23

Closed
tilomitra opened this issue May 24, 2013 · 12 comments
Closed

Remove -webkit and -moz prefixes for border-radius, text-shadow #23

tilomitra opened this issue May 24, 2013 · 12 comments

Comments

@tilomitra
Copy link
Contributor

We don't need to prefix these anymore. All modern browsers support it. The only ones that don't are Android 2.3, but it's ok if they don't get rounded corners.

@tcelestino
Copy link

But not everyone don't use browsers modern.

@caouecs
Copy link

caouecs commented May 28, 2013

+1 with @tcelestino

why don't use SMACSS ?

@briznad
Copy link

briznad commented May 28, 2013

from http://purecss.io/extend/

Based on SMACSS
Pure is broken up into a set of responsive modules. From the beginning, we adopted SMACSS as a convention for writing our CSS.

@tilomitra
Copy link
Contributor Author

@briznad @caouecs What does border-radius have to do with SMACSS? Can you guys be more specific?

@briznad
Copy link

briznad commented May 28, 2013

@tilomitra I don't know. Was just trying to clarify that SMACSS is being utilized.

@caouecs
Copy link

caouecs commented May 28, 2013

sorry, I wanted to talk to Compass

@tilomitra
Copy link
Contributor Author

Sorry guys, I'm not sure what the question is. Are you guys suggesting that we keep border-radius along with it's prefixes, and use some CSS pre-processor to add in the vendor prefixes on build-time? If so, we are looking into this.

@ericf
Copy link
Collaborator

ericf commented May 29, 2013

To me, this is part of a larger task to define the browser support we want for Pure and the "policy" we'll follow for how we want to support the modern, auto-updating browsers. Once that's define, then decisions like this one, and other vendor prefix ones, will be easier to make calls on.

@ericf
Copy link
Collaborator

ericf commented May 29, 2013

I created issue #36

@tilomitra
Copy link
Contributor Author

@ericf I think when it comes to auto-updating browsers, we should always support the latest (n), and n-1. For the case of box-shadow, text-shadow, and border-radius, we can remove these prefixes. Let's just use caniuse.com and our discretion.

@ericf
Copy link
Collaborator

ericf commented Jun 4, 2013

For the case of box-shadow, text-shadow, and border-radius, we can remove these prefixes. Let's just use caniuse.com and our discretion.

Sounds good. Just provide the data that clearly states this is the case in the commit message or something. I guess we're a bit out of the weeds on IE, since IE 9 went non-prefixed on these IIRC. The one caveat will be mobile browsers, does MobileSafari on iOS 5 fit this bill? What about the Android 4.0 (first release)?

tilomitra added a commit to tilomitra/pure that referenced this issue Jun 6, 2013
Removes browser prefixes for CSS properties that don't need prefixes
in supported environments.
tilomitra added a commit to tilomitra/pure that referenced this issue Jun 6, 2013
ericf added a commit that referenced this issue Jun 7, 2013
Fix for issue #23: Remove -webkit and -moz prefixes for older CSS3 properties.
@ericf
Copy link
Collaborator

ericf commented Jun 7, 2013

#69 has been merged. Closing this…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants