Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -webkit-font-smoothing: antialiased #170

Merged
merged 1 commit into from
Aug 23, 2013
Merged

Remove -webkit-font-smoothing: antialiased #170

merged 1 commit into from
Aug 23, 2013

Conversation

dchest
Copy link
Contributor

@dchest dchest commented Aug 23, 2013

[edited]

@lkraav
Copy link
Collaborator

lkraav commented Aug 23, 2013

For those that don't know, like me, what is the problem with this rule?

@dchest
Copy link
Contributor Author

dchest commented Aug 23, 2013

@lkraav It makes fonts look different that what users normally see, as it disables subpixel rendering. It doesn't make sense to do this in a framework such as Pure, which is intended to be a "foundation".

Here's a screenshot:

screen shot

On the left you see a button without -webkit-font-smoothing, on the right is what Pure currently does. You may argue that you like how the right button more, and I'm okay with this opinion, but this button is overriding the user preference (default on LCD displays with most operating systems) for subpixel rendering. It doesn't belong in Pure, it must be a site-specific thing.

Also, since Firefox doesn't implement -webkit-font-smoothing, buttons looks different in FF and Chrome/Safari.

@omeid
Copy link
Contributor

omeid commented Aug 23, 2013

I think it's pretty reasonable to remove this.
Anitialising fundamentally sucks anyways.

@dchest
Copy link
Contributor Author

dchest commented Aug 23, 2013

More on this:

http://www.usabilitypost.com/2012/11/05/stop-fixing-font-smoothing/

I suspect this CSS property was introduced to fix rendering on dark Dashboard widgets in OS X or something (can't read Apple's rdar). Unfortunately, web designers somehow learned about it :-(

@lkraav
Copy link
Collaborator

lkraav commented Aug 23, 2013

Consider me convinced

@ericf
Copy link
Collaborator

ericf commented Aug 23, 2013

@dchest sounds like the right thing to do. Next time could you put something more like your comment as the description, k thanks!

@dchest
Copy link
Contributor Author

dchest commented Aug 23, 2013

@ericf sure, sorry about that, I removed the original "description".

ericf added a commit that referenced this pull request Aug 23, 2013
Remove -webkit-font-smoothing: antialiased
@ericf ericf merged commit 5b2e42a into pure-css:master Aug 23, 2013
@dchest dchest deleted the patch-1 branch September 3, 2013 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants