-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CSS3 Flexbox in Grids when possible #190
Conversation
Use CSS3 Flexbox in Grids when possible
This is starting to hurt. It was possibly to use text-align on inline-blocks before. Now with -webkit-flex, is there no similar unified solution? Have to resort to having two rulesets for these browsers? |
/cc @msweeney |
I think we rushed the Its possible to use class attributes to bind alignment behavior instead of relying on If this sounds reasonable, I can take an initial pass at the requirements based on legacy support. |
Thanks for the attention. In the meanwhile I simply rearranged some structure for this one project and did some good'ol calculated padding instead of text-align. But yeah, flexbox is a bit raw for now.. |
@msweeney It would be great if you could take a pass at that, keeping in mind the responsive grid work that we've been doing. |
This change from @msweeney makes Grids use CSS3 Flexbox when possible in order to avoid the side-effects of setting a negative
letter-spacing
. Theletter-spacing
approach is used as a fallback for older browsers, and the Flexbox rules trump it.This should improve support for Grids across an even larger set of OS/browser combinations, and its ability to withstand the use of non-default fonts when set by either the person in their browser settings or by the developer using custom fonts.
Relates to: #41, #162, #166, #189