Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move build-system for examples into Examples/ #13

Closed
umlaeute opened this issue May 29, 2024 · 7 comments
Closed

move build-system for examples into Examples/ #13

umlaeute opened this issue May 29, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@umlaeute
Copy link
Contributor

we currently have a master CMakeLists.txt file in the project root, the sole purpose of which is to act as an example on how to use pd.cmake.

since it is just an example, i think it should be moved into the Examples/ subdirectory.

we could leave a Cmakefile in the root, that just calls the Examples.

this way, the examples are "self-contained" (without pd.cmake itself) and can also document how to include pd.cmake from arbitrary paths (see my PDCMAKE_DIR in #7 )

@umlaeute umlaeute added the enhancement New feature or request label May 29, 2024
@charlesneimog
Copy link
Collaborator

#10

@umlaeute
Copy link
Contributor Author

it's not related to #10, and i don't see that it is resolved in current master or dev branch.

@umlaeute umlaeute reopened this Jun 18, 2024
@charlesneimog
Copy link
Collaborator

Check 1f0f4f4, I don't think that we need two CMakeLists.txt, one in the root with a simple add_subdirectory for Examples.

@umlaeute
Copy link
Contributor Author

I think otherwise, but I already said everything (explaining why I think so) in the top level post, so I don't know what to add...

charlesneimog added a commit to charlesneimog/pd.cmake that referenced this issue Jun 18, 2024
@charlesneimog
Copy link
Collaborator

ok, I am not sure if I understand, but I implemented what I understood here: 20afecf

@umlaeute
Copy link
Contributor Author

umlaeute commented Jun 18, 2024 via email

@charlesneimog
Copy link
Collaborator

Done in cff4701!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants