Fix warnings revealed by PureScript v0.14.1 (#36)

* Fix dependency warnings * Fix UnusedName warnings on v0.14.1 * Update CHANGELOG.md
purescript-contrib · May 6, 2021 · ea7e558 · ea7e558
1 parent d211820
commit ea7e558
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,8 @@ New features:
 Bugfixes:
 
 Other improvements:
+- Removed unused names found by the v0.14.1 PureScript release (#36)
+- Installed dependencies directly imported into source code that were previously installed transitively and removed unused `record` dependency (#36)
 
 ## [v7.0.0](https://github.com/purescript-contrib/purescript-argonaut-generic/releases/tag/v7.0.0) - 2021-02-26
 

diff --git a/spago.dhall b/spago.dhall
@@ -2,13 +2,19 @@
 , dependencies =
   [ "argonaut-codecs"
   , "argonaut-core"
+  , "arrays"
   , "assert"
+  , "bifunctors"
   , "console"
+  , "control"
   , "effect"
+  , "either"
   , "exceptions"
+  , "foreign-object"
+  , "partial"
   , "prelude"
   , "psci-support"
-  , "record"
+  , "strings"
   ]
 , packages = ./packages.dhall
 , sources = [ "src/**/*.purs", "test/**/*.purs" ]

diff --git a/src/Data/Argonaut/Decode/Generic.purs b/src/Data/Argonaut/Decode/Generic.purs
@@ -35,7 +35,7 @@ decodeRep :: forall r. DecodeRep r => Json -> Either JsonDecodeError r
 decodeRep = decodeRepWith defaultEncoding
 
 instance decodeRepNoConstructors :: DecodeRep Rep.NoConstructors where
-  decodeRepWith e _ = Left $ UnexpectedValue $ fromString "NoConstructors (Cannot decode empty data type)"
+  decodeRepWith _ _ = Left $ UnexpectedValue $ fromString "NoConstructors (Cannot decode empty data type)"
 
 instance decodeRepSum :: (DecodeRep a, DecodeRep b) => DecodeRep (Rep.Sum a b) where
   decodeRepWith e j = Rep.Inl <$> decodeRepWith e j <|> Rep.Inr <$> decodeRepWith e j
@@ -88,13 +88,13 @@ construct e valuesArray decodingErr = do
 instance decodeRepConstructorNoArgs :: IsSymbol name => DecodeRep (Rep.Constructor name Rep.NoArguments) where
   decodeRepWith e j = do
     let name = reflectSymbol (Proxy :: Proxy name)
-    {tag, decodingErr} <- withTag e j name
+    {decodingErr} <- withTag e j name
     construct e [] decodingErr
 else
 instance decodeRepConstructorArg :: (IsSymbol name, DecodeJson a) => DecodeRep (Rep.Constructor name (Rep.Argument a)) where
   decodeRepWith e j = do
     let name = reflectSymbol (Proxy :: Proxy name)
-    {tag, values, decodingErr} <- withTagAndValues e j name
+    {values, decodingErr} <- withTagAndValues e j name
     if e.unwrapSingleArguments
       then construct e [values] decodingErr
       else do
@@ -104,7 +104,7 @@ else
 instance decodeRepConstructor :: (IsSymbol name, DecodeRepArgs a) => DecodeRep (Rep.Constructor name a) where
   decodeRepWith e j = do
     let name = reflectSymbol (Proxy :: Proxy name)
-    {tag, values, decodingErr} <- withTagAndValues e j name
+    {values, decodingErr} <- withTagAndValues e j name
     valuesArray <- note (decodingErr $ AtKey e.valuesKey $ TypeMismatch "Array") (toArray values)
     construct e valuesArray decodingErr