Import Data.Generic.Rep from prelude #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind updating the module names and adding that to the CHANGELOG? |
kl0tl
force-pushed
the
import-Data.Generic.Rep-from-prelude
branch
from
b145d64 to
aa5d6f5
Compare
|
I renamed the modules and updated the changelog. |
kl0tl
force-pushed
the
import-Data.Generic.Rep-from-prelude
branch
from
489b286 to
f5eef1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
We merged generics-rep into prelude and renamed the Data.Generic.Rep.* modules to Data.*.Generic in purescript/purescript-prelude#235. As suggested in #32 we could also rename Data.Argonaut.Decode.Generic.Rep to Data.Argonaut.Decode.Generic, Data.Argonaut.Encode.Generic.Rep to Data.Argonaut.Encode.Generic and Data.Argonaut.Types.Generic.Rep to Data.Argonaut.Types.Generic for consistency.
I updated the bower dependencies to their main or master branch since we forgot to do it earlier.
Close #32.