Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library to Contributors library standards #15

Merged
merged 4 commits into from
Oct 7, 2020

Conversation

maxdeviant
Copy link
Member

This PR updates purescript-matryoshka to adhere to the Contributors library guidelines.

This is part of the purescript-contrib/governance#13 effort.

@maxdeviant
Copy link
Member Author

Verified that the build works and the "tests" run:

λ spago build
[info] Installation complete.
[info] Build succeeded.

λ spago test
[info] Installation complete.
[info] Build succeeded.
expr example
24
list example
24
4 : 3 : 2 : 1 : Nil
720
[info] Tests succeeded.

Once this PR gets merged I'll add issues for the following outstanding items:

  • Adding a "quick start" guide
  • Adding real tests (currently they're just runnable examples)
  • Adding module documentation

@maxdeviant
Copy link
Member Author

Once this PR gets merged I'll add issues for the following outstanding items:

  • Adding a "quick start" guide
  • Adding real tests (currently they're just runnable examples)
  • Adding module documentation

I went ahead and created these issues now, since I forgot to do it once purescript-contrib/purescript-arraybuffer-types#16 was merged 🤦‍♂️

@thomashoneyman
Copy link
Contributor

Couple of minor comments, but otherwise 👍

@thomashoneyman thomashoneyman merged commit 02b0c77 into purescript-contrib:main Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants