Replace logShow with assertEquals' #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asserts did not get good names since I don't know what they intended with the test, but at least they are easy to find due to the unique names they have, since they are named by the expression it tests.
Co-authored-by: Thomas Honeyman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make it easier to add automated tests, and so I started by converting the manual ones that already existed.
Working from the principles of iterative improvement, this PR is not perfect but I'm quite sure it is better then the code that existed, and hope the next person (maybe me) will improve it further.
The asserts did not get good names since I don't know what they intended with the test, but at least they are easy to find due to the unique names they have, since they are named by the expression it tests.
Checklist: