Keep Parser.y ASCII to avoid happy locale issues #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request #3639 also addresses this issue. |
|
A version of stack (version 1.10.0) specifies the LANG env variable. However, it's not even released, let alone available in nixpkgs. However, a haskell utility function "buildStackProject" in nixpkgs already exists that likewise sets the LANG env variable. Invoking it via a nix flag in stack.yaml seems to do the trick. Perhaps ASCII would be better in general -- since it's a simpler, more constrained standard, but keeping Parser.y ASCII to work around the strange behavior of "readFile" by Happy may not be necessary. |
|
I'm fine with merging this, since it unfortunately seems to be the most robust way to deal with this way until a Stack version is released to deal with this issue. |
natefaubion
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to fix some weird locale issues I've ran into with NixOS.
Despite
localereporting a utf-8 locale, when Istack buildthat locale is lost and happy crashes with an encoding error. Probably something to do with how stack manages Nix, but in any case this seems like a straightforward way of avoiding similar issues in future.