Part1. RxJava2 support #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of sqlite and content-resolver.
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
============================================
- Coverage 97.41% 97.05% -0.37%
+ Complexity 791 778 -13
============================================
Files 91 91
Lines 2707 2645 -62
Branches 305 297 -8
============================================
- Hits 2637 2567 -70
- Misses 38 48 +10
+ Partials 32 30 -2
Continue to review full report at Codecov.
|
artem-zinnatullin
approved these changes
Nov 6, 2017
build.gradle
Outdated
| // TODO remove RxJava1 and Interop once RxJava2 migration will be complete. | ||
| rxJava : 'io.reactivex:rxjava:1.2.1', | ||
| rxJavaInterop : 'com.github.akarnokd:rxjava2-interop:0.10.0', | ||
| rxJava2 : 'io.reactivex.rxjava2:rxjava:2.1.4', |
build.gradle
Outdated
|
|
||
| // TODO remove RxJava1 and Interop once RxJava2 migration will be complete. | ||
| rxJava : 'io.reactivex:rxjava:1.2.1', | ||
| rxJavaInterop : 'com.github.akarnokd:rxjava2-interop:0.10.0', |
|
@geralt-encore let's merge this? |
|
Sorry, just saw this PR after your mention. |
geralt-encore
approved these changes
Nov 9, 2017
|
I think that this coverage drop is not that important, so I'll merge it right away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry guys for such huge amount of code, but I have no idea how to make it smaller =(
The both parts (SQLite and ContentResolver) and tests are highly dependent on common api and I'm not sure how interop library can help us.
This part do not handle case when there is no data in storage, I will solve it in next release (proposals about naming of our optional are welcome ;) )
Part of #685