Update ComponentsService.php #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to pass a full namespace into the sprig tag.
|
I see where you’re coming from, but the idea is that all Sprig components share the same namespace and therefore live in the same folder, similar to front-end templates. |
|
Is there any way we can add a hook so this can be overridden? I need this
for client plugins, but I understand not wanting to add it to the core.
…On Mon, May 13, 2024 at 11:39 AM Ben Croker ***@***.***> wrote:
I see where you’re coming from, but the idea is that all Sprig components
share the same namespace and therefore live in the same folder, similar to
front-end templates.
—
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC3XVIATJEH35GP2LB3KPDZCDNBTAVCNFSM6AAAAABHUFYDJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBYGA2DGOBTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
No, this is currently not modifiable. Can you perhaps help me understand your use-case so I can consider it? |
|
Ideally reusable internal plugins using Sprig, so it would be nice to keep
the namespace inside of the plugins so I can drop into multiple client
projects.
…On Mon, May 13, 2024 at 11:48 AM Ben Croker ***@***.***> wrote:
No, this is currently not modifiable. Can you perhaps help me understand
your use-case so I can consider it?
—
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC3XVPZ3X3KZ3SRLWWYZKLZCDOD3AVCNFSM6AAAAABHUFYDJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBYGA3TCMZQGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
That makes sense. I opted to make the namespaced component class a fallback, rather than a priority, in 4695cea. Can you take a look and let me know if that works for you? |
|
That's great, thank you!
…On Mon, May 13, 2024 at 12:18 PM Ben Croker ***@***.***> wrote:
That makes sense. I opted to make the namespaced component class a
fallback, rather than a priority, in 4695cea
<4695cea>.
Can you take a look and let me know if that works for you?
—
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC3XVMBCBFZQC54Z7OQESLZCDRXBAVCNFSM6AAAAABHUFYDJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBYGEZTGMJZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to pass a full namespace into the sprig tag.
This use case would be in the case of having a class component in a custom plugin/module and wanting to keep the code in the same namespace.
As an example:
{{ sprig("\modules\sprig\ClassComponent" }}