Get rid of hash function in MapOf factory functions #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 93.69% 96.83% +3.14%
==========================================
Files 9 8 -1
Lines 1252 1139 -113
==========================================
- Hits 1173 1103 -70
+ Misses 74 30 -44
- Partials 5 6 +1
☔ View full report in Codecov by Sentry. |
puzpuzpuz
force-pushed
the
hash-function-less-mapof-v3
branch
2 times, most recently
from
b3a8173 to
f069c08
Compare
puzpuzpuz
force-pushed
the
hash-function-less-mapof-v3
branch
2 times, most recently
from
f34b8a4 to
91f38aa
Compare
Also upgrades library version to v3
puzpuzpuz
force-pushed
the
hash-function-less-mapof-v3
branch
from
91f38aa to
70d4e1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrades the library version to v3 since it's a breaking change.
All
New*MapOf*functions are now replaced with theNewMapOfandNewMapOfPresizedfunctions. There is no longer a need to provide a user-defined hash function.