Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/interfaces assignments #85

Merged
merged 82 commits into from
Apr 23, 2024
Merged

Feature/interfaces assignments #85

merged 82 commits into from
Apr 23, 2024

Conversation

KiLLuuuhh
Copy link
Contributor

@KiLLuuuhh KiLLuuuhh commented Apr 2, 2024 •
edited
Loading

This is the first draft of the interfaces_assignments module.

The module currently supports the following versions:

  • 22.7
  • 23.1
  • 23.7
  • 24.1

This module supports the following features regarding interface_assignments:

  • update Network Port (e.g. Device) of an existing Interface
  • update Description of an existing Interface
  • raises custom exceptions if Device or Interface is not found on the instance

@KiLLuuuhh KiLLuuuhh self-assigned this Apr 2, 2024
@KiLLuuuhh KiLLuuuhh mentioned this pull request Apr 2, 2024
Open
@KiLLuuuhh KiLLuuuhh linked an issue Apr 2, 2024 that may be closed by this pull request
Module Request: interface assignments module #59
Closed
@KiLLuuuhh KiLLuuuhh marked this pull request as ready for review April 4, 2024 16:12
@KiLLuuuhh KiLLuuuhh requested review from rekup and DonGiovanni83 April 4, 2024 16:16
@DonGiovanni83 DonGiovanni83 added this to the v1.0.0 milestone Apr 17, 2024
@KiLLuuuhh KiLLuuuhh force-pushed the feature/interfaces_assignments branch 2 times, most recently from 4eb8e27 to 9b3915e Compare April 18, 2024 08:48
DonGiovanni83
DonGiovanni83 requested changes Apr 19, 2024
View reviewed changes
molecule/interfaces_assignments/converge.yml Outdated Show resolved Hide resolved
molecule/interfaces_assignments/converge.yml Outdated Show resolved Hide resolved
@KiLLuuuhh KiLLuuuhh force-pushed the feature/interfaces_assignments branch from 739dadd to dc09e10 Compare April 20, 2024 08:54
DonGiovanni83
DonGiovanni83 requested changes Apr 20, 2024
View reviewed changes
plugins/modules/interfaces_assignments.py Outdated Show resolved Hide resolved
plugins/modules/interfaces_assignments.py Show resolved Hide resolved
plugins/module_utils/interfaces_assignments_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/interfaces_assignments_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/module_index.py Outdated Show resolved Hide resolved
plugins/module_utils/module_index.py Outdated Show resolved Hide resolved
plugins/module_utils/module_index.py Outdated Show resolved Hide resolved
plugins/module_utils/module_index.py Outdated Show resolved Hide resolved
plugins/module_utils/opnsense_utils.py Outdated Show resolved Hide resolved
tests/unit/plugins/module_utils/test_interfaces_assignments_utils.py Show resolved Hide resolved
@KiLLuuuhh KiLLuuuhh requested a review from DonGiovanni83 April 22, 2024 08:16
@KiLLuuuhh KiLLuuuhh force-pushed the feature/interfaces_assignments branch 2 times, most recently from 979f517 to 8d4afd5 Compare April 22, 2024 13:13
KiLLuuuhh and others added 27 commits April 23, 2024 17:16
@KiLLuuuhh
added new error
440f323
@KiLLuuuhh
fixed typing issue
6aad142
@KiLLuuuhh
fixed doc issue
e0b131d
@KiLLuuuhh
added fully qualified collection names
97a40bc
@KiLLuuuhh
removed OPNSenseInterfaceNotFoundError
20f61fa
@KiLLuuuhh
applied DonGiovannis suggestions
d2dd989
@KiLLuuuhh
removed InterfaceNotFound error since it is not used
18a1b43
@KiLLuuuhh
restructured get_interfaces method to not rely on removed interfaces_…
0bbd616 
…list module_index entry
@KiLLuuuhh
removed unused entries
65357ce
@KiLLuuuhh
removed unused interfaces_list entry
fdbc875
@KiLLuuuhh
some more module_index updates
e2b0f6f
@KiLLuuuhh @DonGiovanni83
Update plugins/modules/interfaces_assignments.py
12f888a 
Co-authored-by: Fabio Bertagna <[email protected]>
@KiLLuuuhh @DonGiovanni83
Update plugins/module_utils/interfaces_assignments_utils.py
a22c5d4 
Co-authored-by: Fabio Bertagna <[email protected]>
@KiLLuuuhh @DonGiovanni83
Update plugins/module_utils/module_index.py
f4b4e16 
Co-authored-by: Fabio Bertagna <[email protected]>
@KiLLuuuhh @DonGiovanni83
Update plugins/module_utils/module_index.py
10bb7be 
Co-authored-by: Fabio Bertagna <[email protected]>
@KiLLuuuhh @DonGiovanni83
Update plugins/module_utils/module_index.py
4d62477 
Co-authored-by: Fabio Bertagna <[email protected]>
@KiLLuuuhh @DonGiovanni83
Update plugins/module_utils/module_index.py
9ca3dcb 
Co-authored-by: Fabio Bertagna <[email protected]>
@KiLLuuuhh
updated error texts
975f542
@KiLLuuuhh
applied DonGiovanni suggestions
1c61e5a
@KiLLuuuhh
refactored code
cee0d6d
@KiLLuuuhh
reimplements configure_params
2439940
@KiLLuuuhh
final adjustments
60bd9ab
@KiLLuuuhh
finalized module_index
e1b528b
@KiLLuuuhh
updated get_interfaces so that it uses the newly created run_command …
47a746e 
…function
@KiLLuuuhh
updated tests
b7a942b
@KiLLuuuhh
black plugins/module_utils/interfaces_assignments_utils.py
8de206e
@KiLLuuuhh
restructed module_index
253cd91
@KiLLuuuhh KiLLuuuhh force-pushed the feature/interfaces_assignments branch from 8d4afd5 to 253cd91 Compare April 23, 2024 15:16
@KiLLuuuhh KiLLuuuhh merged commit a0876cc into puzzle:main Apr 23, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonGiovanni83 DonGiovanni83 DonGiovanni83 approved these changes

@rekup rekup Awaiting requested review from rekup

Assignees

@KiLLuuuhh KiLLuuuhh

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Module Request: interface assignments module
3 participants
@KiLLuuuhh @DonGiovanni83 @rekup