Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest scrcpy #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to latest scrcpy #7

wants to merge 1 commit into from

Conversation

psyhlo
Copy link

@psyhlo psyhlo commented Jun 13, 2023

Update to latest scrcpy
and it works in vs studio 2022

working in vs studio 2022
@pvdstel
Copy link
Owner

pvdstel commented Jun 13, 2023

Hi @psyhlo!

Thanks for the PR. I'll be honest, I unpublished the extension a while ago. I did not think that many people were interested in this extension at all. Right now I don't even have the extension tools for Visual Studio installed. But since you've gone through the effort of updating it, I think publishing it again would be a good idea 😄

I'll set up my local extension development again, and see how I want to proceed with this. There are some changes I'd like to make to the code, probably refactor some things, but I also want to preserve your contribution here.

@psyhlo
Copy link
Author

psyhlo commented Jun 13, 2023

I think my PR is good point to start from.
May be you should think about not to include scrcpy in the extension, but let the user set where is located.
Overall your extension is great and was disappointed when couldn't install it from the market, so I made the changes and then the PR.

@pvdstel
Copy link
Owner

pvdstel commented Jun 14, 2023

That might be a good idea 🤔 I'll definitely consider not bundling it. The CLI will likely remain stable, so that should work.

Also, I won't be able to work on this in the next few weeks. I'll try to start with this in July. Sorry for the delay 😞

@pvdstel pvdstel self-assigned this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants