Use non-streaming mode and default compression level 6 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The streaming mode (using | before the compression) seems to be quite a bit slower. This restricts the input to a file, but which is typically the case. The compression level of 6 is the default and significantly increases performance with similar compression ratio. In a test using Home Assistant Supervisor's Backup functionality backup time decreased from 4min 21s to 3min 33s without streaming mode, and further down to 2min 32s with compression level set to 6. The compression level 6 increased only by 1MB (at 632.8MB to 633.8MB), altough about 90% of data were not compressable data (JPEG). But also other comparision benchmark only report marginal difference in compression ratio.
|
Currently we can only apply this optimization for non-encryption mode. In Python 3.12, tarfile will support compression levels in streaming mode as well, which should bump speed at least a bit. |
agners
force-pushed
the
lower-compression-level-to-tar-default
branch
from
f11fbb2 to
5fde392
Compare
pvizeli
approved these changes
Oct 18, 2023
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The streaming mode (using | before the compression) seems to be quite a bit slower. This restricts the input to a file, but which is typically the case.
The compression level of 6 is the default and significantly increases performance with similar compression ratio.
In a test using Home Assistant Supervisor's Backup functionality backup time decreased from 4min 21s to 3min 33s without streaming mode, and further down to 2min 32s with compression level set to 6. The compression level 6 increased only by 1MB (at 632.8MB to 633.8MB), altough about 90% of data were not compressable data (JPEG). But also other comparision benchmark only report marginal difference in compression ratio.