Modify atomic_contents_add to accept a filter function #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvizeli
reviewed
Jan 13, 2025
securetar/__init__.py
Outdated
| @@ -385,7 +385,7 @@ def _is_excluded_by_filter(path: PurePath, exclude_list: list[str]) -> bool: | |||
| """Filter to filter excludes.""" | |||
|
|
|||
| for exclude in exclude_list: | |||
| if not path.match(exclude): | |||
| if not path.full_match(exclude): | |||
There was a problem hiding this comment.
That not work as we work with PurePath (without any blocking stats). That is the nice thing on that function to keep it fast
There was a problem hiding this comment.
the full_match method with improved glob support was added in Python 3.13: https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.full_match
emontnemery
changed the title
emontnemery
force-pushed
the
filter_full_match
branch
from
98cc471 to
6db9200
Compare
agners
approved these changes
Jan 14, 2025
agners
reviewed
Jan 14, 2025
Co-authored-by: Stefan Agner <[email protected]>
agners
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
atomic_contents_addto accept a filter function, for improved flexibilityThe filter function is called once for each item, including the item passed to
atomic_contents_add.