Skip to content

Commit

Permalink
Fix failing asv benchmarks in CI (#2352)
Browse files Browse the repository at this point in the history
* Pin asv to latest to fix conda install breakage

* Update whatsnew

* Address reviewer comments
  • Loading branch information
markcampanelli authored Jan 21, 2025
1 parent 9fb2eb3 commit dd10ed4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 15 deletions.
14 changes: 1 addition & 13 deletions .github/workflows/asv_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,7 @@ jobs:
python-version: '3.9'

- name: Install asv
run: pip install asv==0.4.2

# asv 0.4.2 (and more recent versions as well) creates conda envs
# using the --force option, which was removed in conda 24.3.
# Since ubuntu-latest now comes with conda 24.3 pre-installed,
# using the system's conda will result in error.
# To prevent that, we install an older version.
# TODO: remove this when we eventually upgrade our asv version.
# https://github.com/airspeed-velocity/asv/issues/1396
- name: Install Conda
uses: conda-incubator/setup-miniconda@v3
with:
conda-version: 24.1.2
run: pip install asv==0.6.4

- name: Run asv benchmarks
run: |
Expand Down
9 changes: 7 additions & 2 deletions docs/sphinx/source/whatsnew/v0.11.3.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,12 @@ Requirements
~~~~~~~~~~~~


Contributors
~~~~~~~~~~~~
Maintenance
~~~~~~~~~~~
* asv 0.4.2 upgraded to asv 0.6.4 to fix CI failure due to pinned older conda.
(pull:`2352`)


Contributors
~~~~~~~~~~~~
* Mark Campanelli (:ghuser:`markcampanelli`)

0 comments on commit dd10ed4

Please sign in to comment.