Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the link text displayed by the plugin #2

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Revise the link text displayed by the plugin #2

merged 4 commits into from
Aug 14, 2024

Conversation

stichbury
Copy link
Contributor

@stichbury stichbury commented Aug 7, 2024

I've made a slight change to the text that's displayed by the plugin. I think it would also help to bold it or make it slightly larger so it is very easy to spot it.

For bonus points, I'd really like a small coffee cup icon too if that's at all possible? Inline next to the text? I think it would help stand out to the user (they'll get used to looking for it and thus being able to easily find and click through). WDYT?

@maartenbreddels

Change text displayed
@stichbury
Copy link
Contributor Author

stichbury commented Aug 13, 2024

@maartenbreddels @itsjoeoui Just wanted to highlight this PR to you for when you're able to take a look.

I would like to revise the copy slightly that is displayed if possible. I've a draft PR which shows how it looks right now (see here for an example). I think it's getting lost and needs to stand out a bit more.

image

I'd like instead for the copy to be bold and change the wording if that's OK. I also think it would look neat with your logo.
What about this?

image

Example here where I'm pointing to an existing project rather than using the plugin

  • I have changed the text in the PR here
  • I haven't changed the bolding or added the cup. I'm not sure how you'd prefer to do that. WDYT?

cc @maxschulz-COL

@maartenbreddels
Copy link
Contributor

maartenbreddels commented Aug 14, 2024

Hi Jo,

I think both are a good idea. I've pushed the changes on top of this PR, let me know what you think?

Regards,

Maarten

Closes #1

@stichbury
Copy link
Contributor Author

Thanks for this! I'm just working out how to test it but I like the customisation option to change the text! Will let you know when review is complete.

@stichbury
Copy link
Contributor Author

OK tested, thanks to Max, and all is good: I'm happy for you to merge this when you're happy.

Screenshot 2024-08-14 at 18 07 50

@maartenbreddels maartenbreddels merged commit 67e4430 into py-cafe:main Aug 14, 2024
9 of 16 checks passed
@maartenbreddels
Copy link
Contributor

Great, thanks for helping with this Jo and Max!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants