Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read requirements from file in setup.py #110

Closed
wants to merge 2 commits into from
Closed

Conversation

py-mine-bot
Copy link
Collaborator

Fyssion Authored by Fyssion
Jan 20, 2021
Merged Jan 21, 2021


Hi,

I noticed the requirements in requirements.txt and the install_requires in setup.py don't match. This was causing some requirement issues when installing the lastest versions (5.0.0/5.1.0) from PyPI since asyncio-dgram is missing from the setup.py install_requires.

To fix this, I've changed setup.py to read from the requirements files.

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
Jan 20, 2021


Thanks for doing this!
Unfortunately, pinning to exact versions in setup.py is generally discouraged. That TODO should have mentioned pinning to version ranges instead. Would you mind updating the requirements.txt file to have >= symbols instead of ==? I can merge after that.

@py-mine-bot
Copy link
Collaborator Author

Fyssion Authored by Fyssion
Jan 20, 2021


Alright, I think I've done that 👍

@py-mine-bot py-mine-bot added the Github Import This was auto-imported from upstream repository label Feb 17, 2022
@py-mine-bot py-mine-bot deleted the pr110head branch February 17, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github Import This was auto-imported from upstream repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants