-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve TODO about MacOS cannot resolve localhost #620
Conversation
This bug exists deep inside MacOS, so we can't do anything better, than `if` statement, that will replace `localhost` with `127.0.0.1`. BTW, `socket.getaddrinfo('localhost', 0)` returns `::1` twice and `127.0.0.1` twice too.
The only concern I have here is if someone used |
Related: #268. |
We can also raise a warning, when replacing |
I like that idea. Should we do it regardless of the platform, or only on macos? |
With the current implementation, we should raise a warning always, as user that wants to use IPv6 would be really confused. So we probably should replace localhost only on mac as well as raising the warning only there. I would also be annoyed to see this warning for no real reason, especially if I don't know about performance issues with localhost. |
Co-authored-by: ItsDrike <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, now we just hope it doesn't break anything somewhere for someone.
This bug exists deep inside MacOS, so we can't do anything better, than
if
statement, that will replacelocalhost
with127.0.0.1
.BTW,
socket.getaddrinfo('localhost', 0)
returns::1
twice and127.0.0.1
twice too.