Variable name change #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
their intended use.
If there were plans for another major version, I would have been more inclined to accept this into a branch. I don't foresee any other major changes though. |
Hmmm what's stopping me from planning a major release? Perhaps nothing? Is one small rename worth it? I'll merge and bump the major version to release it. |
4.0.0 is out https://pypi.org/project/mcstatus/4.0.0/ |
py-mine-bot
added
the
Github Import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the "retries" variable names in the actionable methods found in
server.pyto 'tries' which better represent what they are being treated as. (Ex previous: when setting retries=0, the method would not try once. However it should try at least once before attempting a retry)