Add warning for out-of-bounds page range in pdfly cat command #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucas-C
approved these changes
Oct 7, 2024
|
Hi @Zingzy This looks great, thank your for your contribution 👍 Could you just run |
|
Hello @Lucas-C, I made the necessary changes. 😄 |
|
Hello @Lucas-C any updates on this? |
|
I merged your MR! Thank you very much for your contribution @Zingzy 👍 |
ebotiab
pushed a commit
to ebotiab/pdfly
that referenced
this pull request
Oct 15, 2024
MartinThoma
added a commit
that referenced
this pull request
Dec 8, 2024
## What's new ### New Features (ENH) - New `booklet` command to adjust offsets and lengths ([PR #77](#77)) - New `uncompress` command ([PR #75](#75)) - New `update-offsets` command to adjust offsets and lengths ([PR #15](#15)) - New `rm` command ([PR #59](#59)) - `metadata`: now also displaying CreationDate, Creator, Keywords & Subject ([PR #73](#73)) - Add warning for out-of-bounds page range in pdfly `cat` command ([PR #58](#58)) ### Bug Fixes (BUG) - `2-up` command, that only showed one page per sheet, on the left side, with blank space on the right ([PR #78](#78)) [Full Changelog](0.3.3...0.4.0)
|
This has been released in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR addresses issue #33 where users attempting to use the
pdfly catcommand to extract a range of pages outside the number of pages in the PDF document do not receive a warning. The following changes have been made:stderrif it is.pytest.skipdecorator from the test case: Enabled thetest_cat_subset_warn_on_missing_pagestest to verify the warning message instderr.Testing
test_cat_subset_warn_on_missing_pagestest passes, confirming that the warning is printed to stderr when the page range is out of bounds.