Skip to content

Commit

Permalink
DEV: Remove TD004 from ignored Ruff rules (#3066)
Browse files Browse the repository at this point in the history
TD004 is a missing colon in TODO. Also remove an obsolete TODO.
  • Loading branch information
j-t-1 authored Jan 22, 2025
1 parent 073527e commit f1b471b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ ignore = [
"UP006", "UP007",
# for the moment, fix it later:
"TD003", # Missing issue link on the line following this TODO
"TD004", # Missing colon in TODO
"TD005", # Missing issue description after `TODO`
"A", # Variable is shadowing a built-in
"B028", # No explicit `stacklevel` keyword argument found
Expand Down
2 changes: 1 addition & 1 deletion tests/test_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ class PositionedText:
"""

def __init__(self, text, x, y, font_dict, font_size) -> None:
# TODO \0-replace: Encoding issue in some files?
# TODO: \0-replace: Encoding issue in some files?
self.text = text.replace("\0", "")
self.x = x
self.y = y
Expand Down
2 changes: 1 addition & 1 deletion tests/test_reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ def test_reader_properties():
[True, False],
)
def test_issue604(caplog, strict):
"""Test with invalid destinations.""" # TODO
"""Test with invalid destinations."""
with open(RESOURCE_ROOT / "issue-604.pdf", "rb") as f:
pdf = None
outline = None
Expand Down

0 comments on commit f1b471b

Please sign in to comment.