Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST : Add multiple retry on get_url #1626

Merged
merged 4 commits into from
Feb 12, 2023
Merged

Conversation

pubpub-zz
Copy link
Collaborator

to reduce fail case due to network issue during committing

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Base: 91.92% // Head: 91.92% // No change to project coverage 👍

Coverage data is based on head (e6aa595) compared to base (7a807d2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1626   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          33       33           
  Lines        6375     6375           
  Branches     1272     1272           
=======================================
  Hits         5860     5860           
  Misses        327      327           
  Partials      188      188           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit 4bf3e32 into py-pdf:main Feb 12, 2023
MartinThoma added a commit that referenced this pull request Feb 12, 2023
Bug Fixes (BUG):
-  Switch from trimbox to cropbox when merging pages (#1622)
-  Text extraction not working with one glyph to char sequence (#1620)

Robustness (ROB):
-  Fix 2 cases of "object has no attribute \'indirect_reference\'" (#1616)

Testing (TST):
-  Add multiple retry on get_url for external PDF downloads (#1626)

[Full Changelog](3.4.0...3.4.1)
@pubpub-zz pubpub-zz deleted the url_retry branch June 24, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants