STY: Slightly increase readability #3098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3098 +/- ##
==========================================
+ Coverage 96.48% 96.51% +0.03%
==========================================
Files 52 53 +1
Lines 8808 8875 +67
Branches 1613 1622 +9
==========================================
+ Hits 8498 8566 +68
Misses 185 185
+ Partials 125 124 -1 ☔ View full report in Codecov by Sentry. |
pypdf/_page.py
Outdated
| index = len_self + index | ||
| if index < 0 or index >= len_self: | ||
| index += len_self | ||
| if not 0 <= index < len_self: |
There was a problem hiding this comment.
I am not sure about this - for me, the old variant is easier to understand.
There was a problem hiding this comment.
Once you get used to it is quicker to parse.
There was a problem hiding this comment.
I honestly have some doubts about this and the old way, the grouping has been easier to grasp - even when dealing with Python code on a daily basis. This needs some further thinking about before merging.
stefan6419846
added
the
on-hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.