ENH: Allow password at constructor

[pubpub-zz]

adding new optional parameter at PdfReader

[codecov]

Codecov Report

Merging #910 (fd33ff0) into main (bbfd46c) will increase coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head fd33ff0 differs from pull request most recent head 54ccbbf. Consider uploading reports for the commit 54ccbbf to get more accurate results

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
+ Coverage   77.81%   77.96%   +0.15%     
==========================================
  Files          16       16              
  Lines        4327     4321       -6     
  Branches      812      815       +3     
==========================================
+ Hits         3367     3369       +2     
+ Misses        788      780       -8     
  Partials      172      172              

Impacted Files	Coverage Δ
PyPDF2/_reader.py	77.25% <100.00%> (+0.23%)	⬆️
PyPDF2/xmp.py	52.06% <0.00%> (ø)
PyPDF2/generic.py	77.90% <0.00%> (+0.12%)	⬆️
PyPDF2/_page.py	79.95% <0.00%> (+0.57%)	⬆️
PyPDF2/_utils.py	90.99% <0.00%> (+1.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7647ab5...54ccbbf. Read the comment docs.

[MartinThoma]

Thank you for the PR ❤️

I can see where you're coming from / why you added it. I thought about this a couple of times myself as well.

I'm torn between two philosophies here:

1. Keep interfaces minimal / avoid "parameter creep"
2. It might be pretty useful / more intuitive than the decrypt method (I have no intention to remove decrypt; it seems just like a valuable addition).

Looking at similar libraries:

• Fitz/PyMuPDF: doc.authenticate(password) seems to be the only option
• pdfrw: no decryption capabilities?
• pikepdf: I couldn't figure out how to decrypt ... it must have those capabilities, though

What is your opinion @MasterOdin ?

[MasterOdin]

@MartinThoma pikepdf offers a password parameter on its pikepdf.Pdf.open method which is decently synonymous with doing PyPDF.PdfReader().

I'm guessing that most people will always want to decrypt a PDF that's being read in before doing any other operations, I feel like baking it into the constructor makes sense.

[MartinThoma]

I made a few stylistic changes / applied black so that CI suceeds. The PR was merged with #920 / c59224a and will be part of the 2.0.0 release.

Thank you for your contribution!