Adding general version of CACM #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit-sharma
reviewed
May 31, 2023
There was a problem hiding this comment.
thanks for this PR @jivatneet Looks good overall. Added a few minor comments. Once you address those, it is ready to merge.
docs/source/example_notebooks/prediction/dowhy_causal_prediction_demo.ipynb
Outdated
Show resolved
Hide resolved
docs/source/example_notebooks/prediction/dowhy_causal_prediction_demo.ipynb
Outdated
Show resolved
Hide resolved
docs/source/example_notebooks/prediction/dowhy_causal_prediction_demo.ipynb
Outdated
Show resolved
Hide resolved
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
jivatneet
force-pushed
the
causal_pred_general
branch
from
2ae0e7b to
24974aa
Compare
Signed-off-by: Jivat Neet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
This reverts commit 6cbc3cb. Signed-off-by: jivatneet <[email protected]>
Signed-off-by: jivatneet <[email protected]>
amit-sharma
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step toward a general causal prediction API. The API supports Causal, Independent, Confounded, and Selected shifts (individual and multi-attribute settings) currently. The regularization has been implemented using
unconditional_regandconditional_regfunctions, which can be used for the general CACM API.Follow up: implement Phase I of CACM for deriving conditional independence constraints given arbitrary graphs.