Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST COVERAGE] Improve test coverage of time-series graph submodule #37

Merged
merged 12 commits into from
Feb 18, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Jan 23, 2023

Signed-off-by: Adam Li [email protected]

Fixes: #52
Towards: #54

Changes proposed in this pull request:

  • Add lots of unit-tests for time series graphs and organizes their implementation more
  • Adds a preliminary user guide for different causal graphs and highlights the alpha functionality of time-series causal graphs

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@adam2392 adam2392 added this to the Release v0.1 milestone Feb 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023

Codecov Report

Merging #37 (51c3283) into main (ba73b32) will increase coverage by 5.28%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   68.98%   74.27%   +5.28%     
==========================================
  Files          27       28       +1     
  Lines        2038     2068      +30     
  Branches      510      527      +17     
==========================================
+ Hits         1406     1536     +130     
+ Misses        526      420     -106     
- Partials      106      112       +6     
Impacted Files Coverage Δ
pywhy_graphs/classes/cpdag.py 73.46% <ø> (ø)
pywhy_graphs/classes/timeseries/digraph.py 91.30% <ø> (ø)
pywhy_graphs/classes/timeseries/pag.py 78.94% <75.00%> (+31.80%) ⬆️
pywhy_graphs/networkx/classes/mixededge.py 81.45% <76.92%> (+0.03%) ⬆️
pywhy_graphs/classes/timeseries/cpdag.py 87.50% <77.77%> (+42.40%) ⬆️
pywhy_graphs/classes/timeseries/graph.py 82.60% <82.60%> (ø)
pywhy_graphs/classes/pag.py 79.03% <100.00%> (+1.44%) ⬆️
pywhy_graphs/classes/timeseries/base.py 84.89% <100.00%> (+0.25%) ⬆️
pywhy_graphs/classes/timeseries/conversion.py 81.81% <100.00%> (ø)
pywhy_graphs/classes/timeseries/mixededge.py 89.65% <100.00%> (+51.05%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adam2392 adam2392 merged commit d58d369 into py-why:main Feb 18, 2023
@adam2392 adam2392 deleted the covts branch February 18, 2023 19:13
@adam2392 adam2392 mentioned this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage of time-series graphs such that we have at least 80-90% coverage
2 participants