Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat repo #499

Merged
merged 1 commit into from
Aug 29, 2023
Merged

reformat repo #499

merged 1 commit into from
Aug 29, 2023

Conversation

smribet
Copy link
Collaborator

@smribet smribet commented Aug 19, 2023

This PR reformats the repo. I think it will make it easier to compare and maintain code.

@alex-rakowski
Copy link
Collaborator

What style did you format with?

@sezelt
Copy link
Member

sezelt commented Aug 29, 2023

I am very much in favor of this change, and I think the overall sentiment at the dev meeting was in favor of this. @bsavitzky do you have any objections? If there are any spots where we really want some non-standard formatting we can mark it with #fmt: off/#fmt: on.

@alex-rakowski
Copy link
Collaborator

alex-rakowski commented Aug 29, 2023

I'm also in favour. I think it would be worth adding a .pre-commit-config.yaml to have black autoformat on each commit for developers. Maybe that should be part of #502

@sezelt
Copy link
Member

sezelt commented Aug 29, 2023

#502 is a step in that direction, but just as a check and not something that will force changes

@bsavitzky bsavitzky merged commit be44354 into py4dstem:dev Aug 29, 2023
@bsavitzky
Copy link
Member

Sigh. Ok! Oh brave new world, with such uncompromising Python code formatters in it. [1][2]

@sezelt I approved PR #502. Unless you want to make additional edits, if you go ahead and un-draft it I/whoever can merge.

@alex-rakowski I don't want to have a .yaml action that modifies developer code just yet. It is, of course, not unreasonable, and I think perhaps we'll get there. For the moment, I'd prefer some stay on ceding control over minutiae of hand coding in favor of speed and determinism on fundamental grounds. [1] Yes, PR#502 defacto does that. Yes, this means you/we have to run black on our code ourselves. By hand. [laughs maniacally]

Let us continue discussion out in the world...

Anywho. Merged!

[1] https://github.com/psf/black
[2] A Brave New World, Huxley

@smribet smribet deleted the black_format branch August 29, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants