Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QAOA testing with real parameters #302

Merged
merged 19 commits into from
Aug 29, 2024
Merged

QAOA testing with real parameters #302

merged 19 commits into from
Aug 29, 2024

Conversation

vedant1729
Copy link
Contributor

No description provided.

gcattan
gcattan requested changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@gcattan gcattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vedant,

Can you remove the pyRiemann-qiskit folder your created?
And move this example to examples/toys_datasets?

test_qaoa.py Outdated Show resolved Hide resolved
test_qaoa.py Outdated Show resolved Hide resolved
test_qaoa.py Outdated Show resolved Hide resolved
test_qaoa.py Outdated Show resolved Hide resolved
@gcattan
Copy link
Collaborator

gcattan commented Aug 10, 2024

Hi @vedant1729 remove pyriemann-qiskit not pyriemann_qiskit :)

@gcattan
Copy link
Collaborator

gcattan commented Aug 28, 2024

@qbarthelemy This is a new implementation of the QAOA optimization, that accepts continuous variables as input, and not only binary.
Can you review these changes? A second review would be great.

qbarthelemy
qbarthelemy reviewed Aug 28, 2024
View reviewed changes
examples/toys_dataset/plot_qaoa_cv.py Outdated Show resolved Hide resolved
examples/toys_dataset/plot_qaoa_cv.py Outdated Show resolved Hide resolved
examples/toys_dataset/plot_qaoa_cv.py Outdated Show resolved Hide resolved
pyriemann_qiskit/utils/docplex.py Outdated Show resolved Hide resolved
pyriemann_qiskit/utils/docplex.py Outdated Show resolved Hide resolved
gcattan
gcattan approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@gcattan gcattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @qbarthelemy !

@gcattan gcattan merged commit 6735683 into pyRiemann:main Aug 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbarthelemy qbarthelemy qbarthelemy left review comments

@gcattan gcattan gcattan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vedant1729 @gcattan @qbarthelemy