Allow to use QAOA-CV optimizer inside classification module #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ityToPenalty - check if cost operator is pauli identity - only one parameter in initial guess? (I am not sure why though)
gcattan
force-pushed
the
feat/qaoa-cv-classification
branch
from
fb82bb1 to
fcad45b
Compare
qbarthelemy
reviewed
Sep 27, 2024
qbarthelemy
requested changes
Sep 27, 2024
pyriemann_qiskit/utils/docplex.py
Outdated
Comment on lines
226
to
227
| """Helper to create a docplex representation of a | ||
| covariance matrix variable. |
There was a problem hiding this comment.
A general remark for all dosctrings of pyRiemann-qiskit:
the short summary must be a one-line summary; you can give more details in the extended summary.
pyriemann_qiskit/utils/docplex.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| covmat : ndarray, shape (n_features, n_features) |
There was a problem hiding this comment.
Two general remarks.
Like in pyRiemann, try to replace inputs called covmat by X, more sklearnistic.
And try to generalize description from covariance matrices to SPD matrices.
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
qbarthelemy
requested changes
Sep 30, 2024
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
qbarthelemy
reviewed
Sep 30, 2024
qbarthelemy
reviewed
Sep 30, 2024
benchmarks/light_benchmark.py
Outdated
Comment on lines
34
to
35
| import sys | ||
| import warnings |
There was a problem hiding this comment.
sys and warnings are standard libraries, and must be imported in the first block of imports.
|
Thank you for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use QAOA-CV docplex optimizer inside the classification module.
To date, only naive QAOA optimizer and classical optimization are available.
Issues: #29, #30