-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote sensing examples #306
Remote sensing examples #306
Conversation
* complete test for time delay cov * update whatsnew * speedup TimeDelayCovariances removing a for loop * Update pyriemann/estimation.py Co-authored-by: Alexandre Gramfort <[email protected]> --------- Co-authored-by: Alexandre Gramfort <[email protected]>
* remove warnings from examples and tests * correct flake8
* improve checking of metric arguments * improve checking of metric arguments bis * improve error messages * last modifs * apply code review remarks
* Enhance ajd module * correct whatsnew * improve code * complete refs * mean ale supporting hpd matrices * remove support of hpd matrices for ajd_pham * last modifs * update version number * modify n_iter_max of ajd_pham * apply suggestions from code review Co-authored-by: Vasco Schiavo <[email protected]> * correct --------- Co-authored-by: Vasco Schiavo <[email protected]>
* use a unique function check_function * complete doc
* change range of window lengths * improve imports in examples * remove useless imports * add blank line
* improve viz module * move plot_cov_ellipse into viz module * add plot_bihist in viz * add reference * garantee to have 0.5 value in bin edges * add matplotlib in requirements * complete whatsnew * correct indentation * add plot_scatter Co-authored-by: gcattan <[email protected]> * correct flake8 * ensure to draw line y=x --------- Co-authored-by: gcattan <[email protected]>
* add class cross spectra * complete whatsnew * correct typo * improve doc
* Add kernel option and tests * Update whatsnew.rst * Update whatsnew.rst * Apply suggestions from code review Co-authored-by: Quentin Barthélemy <[email protected]> * lint * improve whatsnew * Apply suggestions from code review Co-authored-by: Quentin Barthélemy <[email protected]> * linting * add none kernel test * might needed for flake8 * Update embedding.py * Delete .idea/workspace.xml * Update test_embedding.py * Update test_embedding.py * Apply suggestions from code review Co-authored-by: Quentin Barthélemy <[email protected]> * change error * linting --------- Co-authored-by: Quentin Barthélemy <[email protected]>
@qbarthelemy Can you check now ? I also split SAR and hyper spectral in two files because they are two types of images. Next I'll add an example of change detection rather than clustering so that will also be a new file. Ammar |
Thank you @AmmarMian for all this work! My concern is the building time of the documentation: it went from 20 / 30 min to almost 1hour Moreover, currently, you apply a raw downsampling on images, |
I would say it's ok to add Pillow to the doc build reqs
… Message ID: ***@***.***>
|
I had tuned the downsampling so that it doesn't take too long on my PC, but I guess the ressources provided by GitHub actions are quite limited. I reduced the sampling and the Finally,I tweaked the scripts a bit to visualise the images from the data without downsampling and the results with downsampling. I do not really want to use filters because the data is complex-valued for SAR so it's not evident how to approach it. And more importantly, the method relies on a statistical independence of the pixels which could be compromised. To visualize results, I propose to use |
Thanks for all the great advice about radar image processing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @AmmarMian 👍🏻 ! I really like that you can do everything with a sklearn Pipeline. It opens many perspectives: better evaluation, comparison of estimators, ...
Overall, you should replace pca_image
by sklearn.decomposition.PCA
and put it directly in PCAImage
.
Ok so from the input of @antoinecollas, I removed |
Thanks for the changes @qbarthelemy. Let me know if anything more is needed before merging! |
I made some simplifications on PCA. My last question is about |
Indeed you are quite right, I used stuff I had lying around but in this case no need indeed ! We can remove this from the pipeline. Let me do that now and commit again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, a huge thank you for this major contribution to pyRiemann!
A basic example of using pyRiemann to cluster both Hyperspectral images (SPD matrices) or PolSAR images (HPD matrices).
Any input about the coding style is welcomed.
I had to rebase to get all the changes from pyRiemann master branch so I have lots of commits. Please let me know if you'd prefer I make a cleaner version starting from current pyRiemann.