-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify pybind11
as a build-time dependency
#3560
Specify pybind11
as a build-time dependency
#3560
Conversation
…installation
I will run the wheel-building workflow on my fork just to make sure these changes are okay. |
It passes locally for me, strangely! Edit: okay, now passing for Linux and macOS, I just need to fix the Windows tests. We don't compile the IDAKLU solver in PR tests for Windows but we do it when building wheels, so we can check for the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3560 +/- ##
========================================
Coverage 99.59% 99.59%
========================================
Files 258 258
Lines 20755 20755
========================================
Hits 20670 20670
Misses 85 85 ☔ View full report in Codecov by Sentry. |
…bamm-requires`" This reverts commit 2da613d.
I'm closing this PR; it's quite out of date now with what we're planning to do in #3564, and @cringeyburger can take a look at this in the coming weeks. |
Description
This PR adds
pybind11
to the list of build-time dependencies inpyproject.toml
(#3301); which means it is picked up, downloaded, and installed bypip
automatically and therefore made available to users. CMake can now find the package instead of using the git-cloned directory. Contributors and developers will no longer have to git-clone the pybind11 repository from GitHub. All instances ofpybind11
have been moved to a unified location for other workflows to use.Closes #3480
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: