Release notes 24.5 #113
Release notes 24.5 #113
Conversation
✅ Deploy Preview for pybamm-developer-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Agriya Khetarpal <[email protected]>
The links to deleted notebooks in `learn.md` now have been removed. Related to pybamm-team/PyBaMM#3750
|
List of features we should include (IMO):
Please let me know if you think there are others that should be included. I will try to either write them or chase the developers who implemented the features. |
…g into release-notes-24.5
…g into release-notes-24.5
brosaplanella
requested review from
agriyakhetarpal,
martinjrobins,
valentinsulzer,
DrSOKane and
rtimms
|
I implemented all of the above except the plating in composite electrodes as I couldn't find a working example to copy from (and I needed to define additional parameters and I am quite pressed for time this week). Happy to not include or, if someone can suggest a MWE happy to include it. |
|
Hi Ferran. The reason there isn't a worked example for the composite plating is that the only paper I have found that implements it has some parameters missing. I'm strongly in favour of having it available to anyone using the developer install, as I know a few people who want to use it. |
|
Cool! Then happy to include it with a disclaimer about the missing parameters. What options do I need to pass to set the model with composite plating? |
There was a problem hiding this comment.
Thanks very much for picking this up @brosaplanella , this looks great. Could we add an italic subtitle for the main contributor(s) to each feature and their affiliation? This may also encourage people to contribute more and write up about their contributions
|
I have now added the contributors. To be consistent, I pulled all the data (names & institutions) from their Github users when available, and defaulted to the username when not available (even for people we know). Most PRs were from a single contributors, but for the Hackathon one I listed everyone from the PR. I am away from Friday, so might be a bit slow merging that. Once the release happens, feel free to update the date and go ahead merging it. |
|
Thanks, @brosaplanella! I guess we'll make the release on Monday, if someone gets to this before I do, please do so and merge. The style check ( |
There was a problem hiding this comment.
The failing check can be fixed by adding "Meda" to the list of words to ignore -
pybamm.org/.pre-commit-config.yaml
Line 34 in 3b77558
|
Addressed in 99ea446. |
There was a problem hiding this comment.
I'm merging this with the update to the date, as seen in the review comment below so that the release notes are highlighted first. The theme currently doesn't support displaying two news items on the home page simultaneously, so we will have to remove the advertisement blog post from the headline for now.
Important
Do not merge until final release for 24.5 has been published!
Given that I forgot last time, starting the document for next release now so we can add features as we go. Ideally we want the authors of the relevant PRs to add a paragraph here, so we just need to make small edits when the release occurs.