Test: Numpy Scalar Creation #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
commented
Sep 17, 2018
tests/test_numpy_array.cpp
Outdated
| @@ -104,6 +104,8 @@ TEST_SUBMODULE(numpy_array, sm) { | |||
|
|
|||
| // test_empty_shaped_array | |||
| sm.def("make_empty_shaped_array", [] { return py::array(py::dtype("f"), {}, {}); }); | |||
| // test numpy scalars (empty shape, ndim==0) | |||
| sm.def("scalar_int", []() { int i = 42; return py::array(py::dtype("i"), {}, {}, &i); }); | |||
There was a problem hiding this comment.
ups, local var, dangling ref
I found that te numpy array tests already contained an empty-shaped array test, but none with data in it. Following PEP 3118, scalars have an empty shape and ndim 0. This works already and is now also documented/covered by a test.
ax3l
force-pushed
the
test-numpyScalars
branch
from
47d7e1b to
6fa8cb5
Compare
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that te numpy array tests already contained an empty-shaped array test, but none with data in it.
Following PEP 3118, scalars have an empty shape and ndim 0. This works already and is now also documented/covered by a test.
Side note for readers: as documented here, Numpy < 1.15 is bugged when handling scalars.