-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docstring generation tweaks #2212
Conversation
99e261e
to
ddcd659
Compare
Hi Sergei, I'm helping out reviewing PRs, to take some load off Wenzel. Could you please split this PR into 3? E.g. commits 1-4 stay in this PR, 5, 6 each get their separate PR. That will allow me and Wenzel to act quicker on 1-4, and give us separate contexts to discuss the points you're raising. I'll look again asap after the split. |
Hi, Ralf! Thanks for looking into that. I've split PR in three as you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, just a minor question about tests for Iterable & Iterator.
I think inserting the numpy.
is great for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sergei!
fixed silenced flake8 spacing complaints (travis.org seems to become quite unstable recently, probably migration to .com is required) |
These all look good to me, thanks! |
This PR contains a couple of trivial tweaks which make generated docstring a bit better.
compare.cpp