[smart_holder] Simplification: Enable smart_holder functionality unconditionally. #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example error message (🐍 3.11 • ubuntu-latest • x64, GNU 13.3.0):
```
include/pybind11/detail/value_and_holder.h:56:52: error: ‘uint8_t’ is not a member of ‘std’; did you mean ‘wint_t’?
56 | inst->nonsimple.status[index] &= (std::uint8_t) ~instance::status_holder_constructed;
| ^~~~~~~
```
…a follow-on PR that actually changes the internals.
rwgk
changed the title
|
I'm ignoring this failure: 🐍 3.12 • macos-13 • x64 -DCMAKE_CXX_FLAGS="-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT" It is just a catch2 download error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-on to PR #5530 on master.
Now that we don't have to worry about
PYBIND11_INTERNALS_VERSIONs4and5anymore, a lot of#ifdefclutter can be removed from the smart_holder branch.This PR has NO FUNCTIONAL CHANGES in the code that remains, it only removes obsolete functionality.
This PR does NOT change the
PYBIND11_INTERNALS_VERSIONon the smart_holder branch. This is left for the follow-on PR #5541, which removes the obsoletepybind11::detail::type_info::default_holdermember.Notes:
The "Files changed" under this PR are best viewed with the Hide whitespace option.
Sorry the "sh_internals_version_7" branch name for this PR is now misleading. The internals version will only be changed in the follow-on PR [smart_holder] Remove obsolete
detail::type_info::default_holdermember. #5541, because the related code changes are the only changes that are not reviewed already.Suggested changelog entry: