Add delegate support for dpi scaling Fix #93 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadmv
changed the title
mottosso
reviewed
Oct 30, 2020
pyblish_lite/window.py
Outdated
| @@ -1062,3 +1066,9 @@ def heads_up(self, title, message, command=None): | |||
|
|
|||
| # TODO(marcus): Implement this. | |||
| self.info(message) | |||
|
|
|||
| def paintEvent(self, event): | |||
| scale = self.windowHandle().screen().logicalDotsPerInch() / 96.0 | |||
|
Nice one Chad, happy to merge this once you're happy and preferably tested on a Linux flavour. Alternatively, put the use of the feature behind a Would you mind incrementing the version as well? Then I can make a new release to PyPI right away. |
|
Hm, I think this only works with Qt 5, as QScreen was only introduced by then. So we'd also need a flag for anyone using Qt 4 (e.g. Maya 2016 and below) |
|
All that's needed for this one is an |
Limit scaling adjustment to Qt5 and Windows since only tested in Windows
|
Woho! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the delegates to support dpi scaling. Only tested on Windows.